[dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section in rte_cfgfile_close

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Jun 18 14:29:44 CEST 2015


2015-06-17 16:48, Maciej Gajdzica:
> From: Pawel Wodkowski <pawelx.wodkowski at intel.com>
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski at intel.com>

What is fixed exactly? What was the problem?

> @@ -60,6 +60,15 @@ struct rte_cfgfile {
>   * for new entries do we add in */
>  #define CFG_ALLOC_ENTRY_BATCH 16
>  
> +/* Helpers */
> +
> +#define _skip_spaceses(str) ({  \
> +	__typeof__(str) p = (str);  \
> +	while (isspace(*p))         \
> +		p++;                    \
> +	p;                          \
> +})

This macro is not used in this patch nor related.
Is "spaceses" a typo?

> @@ -523,7 +530,7 @@ const char *
>  rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname,
>  		const char *entryname)
>  {
> -	int i;
> +	size_t i;

Why this change? seems not related to free.





More information about the dev mailing list