[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

Wang, Liang-min liang-min.wang at intel.com
Sat Jun 27 04:39:26 CEST 2015



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, June 26, 2015 9:34 PM
> To: Wang, Liang-min
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
> 
> On Fri, 26 Jun 2015 21:19:05 -0400
> Liang-Min Larry Wang <liang-min.wang at intel.com> wrote:
> 
> > +	reg_group = reg_set[g_ind++];
> > +	while (reg_group) {
> > +		count += ixgbe_regs_group_count(reg_group);
> > +		reg_group = reg_set[g_ind++];
> > +	}
> 
> I don't care what checkpatch says, this an example of a loop
> which reads better as:
> 
>         while ((reg_group = reg_set[g_ind++]))
>                count += ixgbe_regs_group_count(reg_group);

There is no specific guideline on which to follow besides running checkpatch.
Maybe this type of exception should be listed on dpdk web-link.
This suggestion is taken on v10.




More information about the dev mailing list