[dpdk-dev] [PATCH v7] af_packet: Fix some klocwork errors
John W. Linville
linville at tuxdriver.com
Thu Mar 12 18:09:19 CET 2015
On Thu, Mar 12, 2015 at 09:38:46AM -0400, Neil Horman wrote:
> On Thu, Mar 12, 2015 at 10:43:24AM +0000, Qiu, Michael wrote:
> > On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> > > Fix possible memory leak issue: free kvlist before return;
> > > Fix possible resource lost issue: close qssockfd before return;
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang at intel.com>
> > > ---
> > > Change in v7:
> > > - Remove unnecessary '!= NULL' check before freeing it;
> > >
> > > Change in v6:
> > > - Refine exit point;
> > >
> > > Change in v5:
> > > - Initialize qsockfd with -1;
> > >
> > > Change in v4:
> > > - Check sockfd in internals->rx_queue against 0;
> > >
> > > Change in v3:
> > > - Also close sockets for all queues;
> > >
> > > Change in v2:
> > > - Make the error exit point a common path.
> >
> > Acked-by: Michael Qiu <michael.qiu at intel.com>
> Acked-by: Neil Horman <nhorman at tuxdriver.com>
Acked-by: John W. Linville <linville at tuxdriver.com>
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
More information about the dev
mailing list