[dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize the VXLAN sample

Liu, Jijiang jijiang.liu at intel.com
Mon May 18 03:37:07 CEST 2015


Hi Stephen,

Thanks for reviewing the patch.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Saturday, May 16, 2015 7:54 AM
> To: Liu, Jijiang
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize the
> VXLAN sample
> 
> I agree that this is great to see a real example of this
> 
> On Fri, 15 May 2015 14:08:52 +0800
> Jijiang Liu <jijiang.liu at intel.com> wrote:
> 
> > +static unsigned
> > +check_ports_num(unsigned nb_ports)
> > +{
> > +	unsigned valid_nb_ports = nb_ports;
> > +	unsigned portid;
> > +
> > +	if (nb_ports > nb_ports) {
> > +		RTE_LOG(INFO, VHOST_PORT, "\nSpecified port number(%u)
> exceeds total system port number(%u)\n",
> > +			nb_ports, nb_ports);
> > +		nb_ports = nb_ports;
> 
> This looks repetative, and wrong, is it something to shut up a compiler warning?
> or something that happened as result of global replace?

Yes, it happened as result of global replace. I will fix this in next  patch version.




More information about the dev mailing list