[dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Nov 10 17:10:37 CET 2015


Hi,

> -----Original Message-----
> From: David Marchand [mailto:david.marchand at 6wind.com]
> Sent: Thursday, October 29, 2015 8:47 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: fix icmp echo tx queues
> 
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
> 
> Signed-off-by: David Marchand <david.marchand at 6wind.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index cf2aa6e..314215c 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void)
>  			fs->rx_port = fwd_ports_ids[rxp];
>  			fs->rx_queue = rxq;
>  			fs->tx_port = fs->rx_port;
> -			fs->tx_queue = lc_id;
> +			fs->tx_queue = rxq;
>  			fs->peer_addr = fs->tx_port;
>  			if (verbose_level > 0)
>  				printf("  stream=%d port=%d rxq=%d
> txq=%d\n",
> --
> 1.9.1

Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>


More information about the dev mailing list