[dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function.

Bruce Richardson bruce.richardson at intel.com
Fri Nov 13 11:00:25 CET 2015


On Fri, Nov 13, 2015 at 02:28:13PM +0800, kamasamikon wrote:
> Give user a chance to costomize the hash key compare function.
> The default rte_hash_cmp_eq function is set in the rte_hash_create
> function, but these builtin ones may not good enough, so the user
> may call this to override the default one.
> 
> Signed-off-by: Yu Nemo Wenbin <yuwb_bjy at ctbri.com.cn>
> ---
Hi,

Just a few small comments:

When adding a new function, you'll need to update the map file for the library
with the new API so it can be correctly versionned.

Also, using function pointers does not work with DPDK multi-process, so, at 
minimum, you need to add to the doxygen documentation that your new function cannot
be used in multi-process mode.

/Bruce


More information about the dev mailing list