[dpdk-dev] [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()

[Panu Matilainen]

On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai at redhat.com>
>
> Acked-by: John McNamara <john.mcnamara at intel.com>
>
> Out of curiosity, how did you identify this issue?

These kind of issues are hard not to notice when using shared library 
configuration once there's something actually using the symbol. In this 
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40 
and fm10k pmds unloadable respectively:

librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve

Driver autoloading does help unearthing these issues too since all the 
pmd's get loaded regardless of the actual hardware present.

	- Panu -