[dpdk-dev] [PATCH] i40e: skip any phy config as a workaround

[Zhang, Helin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 24, 2015 6:17 AM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround
> 
> 2015-11-17 15:09, Helin Zhang:
> > As firmware does not support any link control from software driver
> > side, any phy config should be ignored as a workaround. Otherwise the
> > link might not be up again after binding back to kernel driver.
> >
> > Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> [...]
> > +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw,
> > +		   __rte_unused uint8_t abilities,
> > +		   __rte_unused uint8_t force_speed) {
> > +	/* Skip any phy config on both 10G and 40G interfaces, as a
> workaround
> > +	 * for the link control limitation of that all link control should be
> > +	 * handled by firmware. It should follow up if link control will be
> > +	 * opened to software driver in future firmware versions.
> > +	 */
> >  	return I40E_SUCCESS;
> >  }
> 
> An error code seems more appropriate.
> But I guess you perfectly know what you do, so Applied, thanks

Yes, for now, I'd prefer to use I40E_SUCCESS. We will continue working on this when
firmware provides the link control to sw driver. Thank you very much!

Regards,
Helin