[dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Nov 27 19:50:17 CET 2015


2015-11-27 09:55, Chen Jing D:
> From: "Chen Jing D(Mark)" <jing.d.chen at intel.com>
> 
> Steps to reproduce the bug:
> 1. All Rx offloading is disabled and start the device, then
>    Vector Rx is used.
> 2. Stop the device. Re-configure to enable hw_ip_checksum = 1,
>    start the device again.
> 3. In this case, assume regular Rx should be used since Vector
>    Rx doesn't support ip checksum offload. But actually Vector
>    Rx is used and cause checksum won't be done by hardware.
> 
> The reason is after re-configuring, driver misses an "else" in
> func fm10k_set_rx_function(). Then Rx func in last round are
> used.
> 
> Fixes:77a8ab47("fm10k: select best Rx function")

git log -1 --abbrev=12 --format='Fixes: %h ("%s")' 77a8ab47
Fixes: 77a8ab47eb38 ("fm10k: select best Rx function")

> Reported-by: Xiao Wang <xiao.w.wang at intel.com>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com>
Acked-by: Xiao Wang <xiao.w.wang at intel.com>

Applied, thanks


More information about the dev mailing list