[dpdk-dev] [PATCH v6 06/10] mk: Add rule for installing sdk files

[Thomas Monjalon]

Hi,

2015-11-10 11:07, Mario Carrillo:
> Add hierarchy-file support to the DPDK makefiles, scripts,
> examples, tools, config files and headers,
> when invoking "make install-sdk" makefiles, scripts,
> examples, tools, config files will be installed in:

The tools are part of the runtime, not the sdk.

> $(DESTDIR)/$(SDK_DIR)
> and headers will be installed in:
> $(DESTDIR)/$(INCLUDE_DIR)
> where SDK_DIR=$(RTE_PREFIX)/share/dpdk,
> INCLUDE_DIR=$(RTE_PREFIX)/include/dpdk
> RTE_PREFIX=/usr/local by default, you can override RTE_PREFIX, SDK_DIR
> and INCLUDE_DIR vars.
> This hierarchy is based on:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html

It would be better to follow the GNU standard to name the variables:
https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
https://www.gnu.org/prep/standards/html_node/DESTDIR.html

prefix ?= /usr/local
exec_prefix ?= $(prefix)
bindir ?= $(exec_prefix)/bin
sbindir ?= $(exec_prefix)/sbin
libdir ?= $(exec_prefix)/lib
includedir ?= $(prefix)/include/dpdk
datarootdir ?= $(prefix)/share
docdir ?= $(datarootdir)/doc/dpdk
datadir ?= $(datarootdir)/dpdk

I would add:

kerneldir ?= $(exec_prefix)/kmod
sdkdir ?= $(datadir)