[dpdk-dev] [PATCH 0/3] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER

Jerome Jutteau jerome.jutteau at outscale.com
Fri Oct 16 11:08:47 CEST 2015


Hi,

I have a bug when Qemu with two vhost interfaces gently stops (SIGINT).
When stopping, it sends two RESET_OWNER for each interface:
- Before stopping, we have two interfaces identifers: 0 and 1.
- The first reset_owner call resets device 1 (and this id device_fh) to zero,
  the device list now contains two devices with id 0.
- The second call don't find device 1 and segfault as reset_owner don't
  check if the device has been found or not.
- Later, user_get_vring_base can also segfault for the same reason.

This series of patches propose to fix the way reset_owner alter a device and
add more checks when searching for a device.

Jerome Jutteau (3):
  vhost: avoid device identifier to be reset to 0 in reset_owner
  vhost: check that a device exists during reset_owner
  vhost: protect user_get_vring_base from unknown devices

 lib/librte_vhost/vhost_user/virtio-net-user.c | 2 ++
 lib/librte_vhost/virtio-net.c                 | 5 +++++
 2 files changed, 7 insertions(+)

-- 
jerome



More information about the dev mailing list