[dpdk-dev] [PATCH 5/5] virtio: optimize transmit enqueue

Xie, Huawei huawei.xie at intel.com
Tue Oct 20 03:48:41 CEST 2015


On 10/19/2015 1:16 PM, Stephen Hemminger wrote:
> All the error checks in virtqueue_enqueue_xmit are already done
> by the caller. Therefore they can be removed to improve performance.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Exactly the same thought as i commented in previous patch. We should
remove unnecessary checks as caller ensures they will pass.
We need check whether we need recheck "need" again after
virtio_xmit_cleanup for the previous indirect patch.
 
Acked-by: Huawei Xie <huawei.xie at intel.com>
> ---
>  drivers/net/virtio/virtio_rxtx.c | 23 ++---------------------
>  1 file changed, 2 insertions(+), 21 deletions(-)
>
>



More information about the dev mailing list