[dpdk-dev] [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error

Harish Patil harish.patil at qlogic.com
Fri Oct 23 18:36:22 CEST 2015


>
>2015-09-11 17:42, Rasesh Mody:
>>      #define SHMEM_EEE_ADV_STATUS_MASK          0x00f00000
>>              #define SHMEM_EEE_100M_ADV         (1<<0)
>> -            #define SHMEM_EEE_1G_ADV           (1<<1)
>> +            #define SHMEM_EEE_1G_ADV           (1U<<1)
>>              #define SHMEM_EEE_10G_ADV          (1<<2)
>
>Why other constants are not changed?
I only addressed the build error which is against SHMEM_EEE_1G_ADV.
Is that okay?
>
>Please put at least the build error in the message.
>
Sure, will include the build error and submit new patch.

drivers/net/bnx2x/elink.c:10384:41: error: shifting a
      negative signed value is undefined [-Werror,-Wshift-negative-value]
                vars->eee_status &= ~SHMEM_EEE_1G_ADV <<
                                    ~~~~~~~~~~~~~~~~~ ^
1 error generated.
make[6]: *** [elink.o] Error 1
make[5]: *** [bnx2x] Error 2
make[4]: *** [net] Error 2
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-clang_install] Error 2
make: *** [install] Error 2



________________________________

This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.


More information about the dev mailing list