[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

Sergio Gonzalez Monroy sergio.gonzalez.monroy at intel.com
Tue Oct 27 13:01:08 CET 2015


On 27/10/2015 11:42, Sergio Gonzalez Monroy wrote:
> On 21/10/2015 17:22, shesha Sreenivasamurthy (shesha) wrote:
>> When an application using huge-pages crash or exists, the hugetlbfs
>> backing files are not cleaned up. This is a patch to clean those files.
>> There are multi-process DPDK applications that may be benefited by those
>> backing files. Therefore, I have made that configurable so that the
>> application that does not need those backing files can remove them, thus
>> not changing the current default behavior. The application itself can
>> clean it up, however the rationale behind DPDK cleaning it up is, DPDK
>> created it and therefore, it is better it unlinks it.
>>
>> Signed-off-by: Shesha Sreenivasamurthy <shesha at cisco.com>
>> ---
>>   lib/librte_eal/common/eal_common_options.c | 12 ++++++++++++
>>   lib/librte_eal/common/eal_internal_cfg.h   |  1 +
>>   lib/librte_eal/common/eal_options.h        |  2 ++
>>   lib/librte_eal/linuxapp/eal/eal_memory.c   | 30
>> ++++++++++++++++++++++++++++++
>>   4 files changed, 45 insertions(+)
>>
> You need to update patchwork to reflect that v4 is rejected and set v3 
> with 'New' state.
>
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>
Hi Shesha,

Even though the test-report says the patch is good, it is not. For some
reason it is wrapping some lines (76, 93, 106, 129) causing the errors.

You can add my Acked-by when you resend the patch.

Sergio


More information about the dev mailing list