[dpdk-dev] [PATCH v3 36/36] doc: update release notes for e1000 base code update

Lu, Wenzhuo wenzhuo.lu at intel.com
Wed Oct 28 03:33:13 CET 2015


Hi John,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, October 27, 2015 11:32 PM
> To: Lu, Wenzhuo
> Cc: dev at dpdk.org; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v3 36/36] doc: update release notes for
> e1000 base code update
> 
> 2015-10-16 10:51, Wenzhuo Lu:
> >  New Features
> >  ------------
> >
> > +* **Updated the e1000 base driver.**
> > +  The e1000 base driver was updated with several changes including the
> > +  following:
> > +
> > +  * Add some new i218 devices
> > +  * Fix issue with link flap on 82579
> > +  * Fix issue with jumbo frame CRC failures in client
> > +  * Add support for inverted format ETrackId
> > +  * Add flags to set eee advertisement modes
> > +  * Prevent ulp flow if cable connected
> > +  * Cleanup NAHUM6LP_HW tags
> 
> Is it really a feature?
> 
> > +  * Use the correct i210 register for EEMNGCTL
> > +  * Fix to enable both ulp and EEE in Sx state
> > +  * Fix link detect flow
> > +  * Set correct value of beacon duration
> > +  * Disable extension header parsing for IPv6
> > +  * Fix for i354 88E1112 PHY using AutoMedia Detect
> > +  * Implement 88E1543 PHY initialization
> > +  * Increase timeout of polling bit RSPCIPHY in check_reset_block
> > +  * Synchronization of MAC-PHY interface only on non- ME systems
> 
> Some of theses features are not easy to understand.
> Please avoid to speak of the registers in the release notes.
> Something more high level is expected.
> 
> > +  See the git log for full details of the e1000/base changes.
> 
> This last sentence is valuable for any entry in the release notes.
> Let's say it is implicit.
> 
> >  Resolved Issues
> >  ---------------
> 
> Some of the fixes above should be in this section.
> 
> John, please could you check?
> 
> Thanks

Some fixes should be moved to Resolved Issues. But not sure if the "**Updated the e1000 base driver.**" still needed or describe them separately.
John, can you comment? Thanks. 


More information about the dev mailing list