[dpdk-dev] [PATCH v3 6/6] test: add checks for cpu flags on armv8

Hunt, David david.hunt at intel.com
Fri Oct 30 17:28:25 CET 2015


On 30/10/2015 16:11, Jan Viktorin wrote:
> Hmm, I see. It's good to fix this in the generated e-mails between format-patch
 > and send-email calls. I always review those to be sure they meet my 
expectations ;).
> Anyway, it is not clear, what has changed in the v3. Just the rte_cycles?
> You should explain that at least in the 0000 patch. Better to keep some history
> in each single commit (are there any rules in dpdk for this? Just look how they do in kernel).
--snip--

Sure, I'll keep that in mind for the next time. A list of changes for 
each revision, and also changes in each patch in the patch set. As 
Thomas says - whatever helps the reviewer :)

For the moment there probably isn't a need to release a new patch set 
for these comments, so I'll just list them here:
1. v3 has just the additional comment in one of the patches to say that 
the armv8 header files are in the 'arm' include directory.
2. The rte_cycles is unchanged, the CONFIG_ is not needed.

If there is a need to post another patch set I'll include the change 
notes. Otherwise do we all think that the patch is there (or there 
abouts)? :)

Regards,
Dave.



More information about the dev mailing list