[dpdk-dev] [PATCH v2 04/11] virtio: add xstats() implementation

Stephen Hemminger stephen at networkplumber.org
Wed Sep 30 19:44:57 CEST 2015


On Wed, 30 Sep 2015 10:40:15 +0100
Harry van Haaren <harry.van.haaren at intel.com> wrote:

> +/* [rt]x_qX_ is prepended to the name string here */
> +static const struct rte_virtio_xstats_name_off rte_virtio_q_stat_strings[] = {
> +	{"packets", offsetof(struct virtqueue, packets)},
> +	{"bytes", offsetof(struct virtqueue, bytes)},
> +	{"errors", offsetof(struct virtqueue, errors)},
> +}

I don't see the point of this. The point of xstats is to tell the application
about statistics not available through other means.

These stats should be available already in the per queue stats.


More information about the dev mailing list