[dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD

Stephen Hemminger stephen at networkplumber.org
Fri Apr 1 17:44:40 CEST 2016


On Thu, 31 Mar 2016 19:15:17 -0700
Rasesh Mody <rasesh.mody at qlogic.com> wrote:

> Hi Thomas, Bruce,
> 
> The v5 series incorporates the following review comments:
>  - move adapter_info logs under debug
>  - implement qede_mac_addr_remove()
>  - remove unused rc variable in qede_dev_configure()
>  - fix indentation in qede_dev_info_get()
>  - use c99 style struct init in qede_config_accept_any_vlan()
>  - check error in qede_config_rx_mode()
>  - update overview.rst since patch didn't apply
> 
> The patches are generated and tested against latest dpdk based off of
> v16.04-rc2.
> 
> These patches are checked using checkpatch.sh with following additional
> ignore option:
>    options="$options --ignore=BIT_MACRO,CONCATENATED_STRING"
> 
> Please apply!

Looks good.

One question, is there any restriction on number of Tx queues, relative
to number of Rx queues.  Is it possible to have 8 Tx queues but only 2 Rx queues?
I know bnx2x and some other drivers have that kind of restriction.

Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list