[dpdk-dev] [PATCH] examples/netmap_compat: fix infinite loop

Michal Kobylinski michalx.kobylinski at intel.com
Fri Apr 22 12:47:29 CEST 2016


Fix issue reported by Coverity.

Coverity ID 30701: Infinite loop: The loop does not have a normal
termination condition, so will continue until an abnormal condition
arises. In rte_netmap_poll: Infinite loop with unsatisfiable exit
condition.

Fixes: 06371afe394d ("examples/netmap_compat: import netmap compatibility example")

Signed-off-by: Michal Kobylinski <michalx.kobylinski at intel.com>
---
 examples/netmap_compat/lib/compat_netmap.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/examples/netmap_compat/lib/compat_netmap.c b/examples/netmap_compat/lib/compat_netmap.c
index bf1b418..8cb5764 100644
--- a/examples/netmap_compat/lib/compat_netmap.c
+++ b/examples/netmap_compat/lib/compat_netmap.c
@@ -865,6 +865,11 @@ rte_netmap_poll(struct pollfd *fds, nfds_t nfds, int timeout)
 	uint32_t i, idx, port;
 	uint32_t want_rx, want_tx;
 
+	if (timeout > 0) {
+		ret = -1;
+		return ret;
+	}
+
 	ret = 0;
 	do {
 		for (i = 0; i < nfds; i++) {
-- 
1.9.1



More information about the dev mailing list