[dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound
Dumitrescu, Cristian
cristian.dumitrescu at intel.com
Thu Apr 28 12:58:54 CEST 2016
> -----Original Message-----
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Zhang, Roy Fan
> <roy.fan.zhang at intel.com>; Singh, Jasvinder <jasvinder.singh at intel.com>
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
> <slawomirx.mrozowicz at intel.com>
> Subject: [PATCH v2] examples/qos_sched: fix negative loop bound
>
> From: Slawomir Mrozowicz <slawomirx.mrozowicz at intel.com>
>
> Coverity ID 30704: Negative loop bound
> negative_returns: Using unsigned variable n_tokens in a loop exit condition.
>
> Fixes: de3cfa2c9823 ("sched: initial import")
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz at intel.com>
> ---
> examples/qos_sched/args.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> index 3e7fd08..7a98e5c 100644
> --- a/examples/qos_sched/args.c
> +++ b/examples/qos_sched/args.c
> @@ -162,7 +162,7 @@ static int
> app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals,
> uint32_t *opt_vals)
> {
> char *string;
> - uint32_t i, n_tokens;
> + int i, n_tokens;
> char *tokens[MAX_OPT_VALUES];
>
> if (conf_str == NULL || opt_vals == NULL || n_vals == 0 || n_vals >
> MAX_OPT_VALUES)
> --
> 1.9.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
More information about the dev
mailing list