[dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver

Wu, Jingjing jingjing.wu at intel.com
Fri Apr 29 03:34:46 CEST 2016


Hi, David

For the changes on igb, ixgbe, I saw you create a new header file called **__pci_dev_ids.h to replace the rte_pci_dev_ids.h for each driver.
But for the changes on i40e, you didn't do that way.
If you look into the base code, you will find for each Intel NIC, the device ids are defined there, such as ixgbe_type.h; i40e_devid.h; E1000_hw.h.

I'd prefer the way you did in i40e driver. It's clearer and with minor change.

Thanks
Jingjing

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand
> Sent: Wednesday, April 20, 2016 8:44 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; stephen at networkplumber.org;
> Richardson, Bruce; nhorman at tuxdriver.com; pmatilai at redhat.com;
> christian.ehrhardt at canonical.com; Zhang, Helin; Ananyev, Konstantin
> Subject: [dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver
> 
> test application and kni still want to know ixgbe pci devices.
> So let's create a header in the driver that will be used by them.
> 
> Same comment as for e1000 driver, we can't reuse base/ headers at the
> moment because of macros redefinitions nightmare.
> 
> Signed-off-by: David Marchand <david.marchand at 6wind.com>
> ---
>  app/test-pmd/Makefile                           |   2 +
>  app/test-pmd/cmdline.c                          |   2 +-
>  app/test/Makefile                               |   1 +
>  app/test/test_pci.c                             |   2 +-
>  drivers/net/ixgbe/ixgbe_ethdev.c                |   4 +-
>  drivers/net/ixgbe/ixgbe_pci_dev_ids.h           | 213
> ++++++++++++++++++++++++
>  lib/librte_eal/common/include/rte_pci_dev_ids.h | 154 -----------------
>  lib/librte_eal/linuxapp/kni/Makefile            |   1 +
>  lib/librte_eal/linuxapp/kni/kni_misc.c          |   4 +-
>  9 files changed, 223 insertions(+), 160 deletions(-)  create mode 100644
> drivers/net/ixgbe/ixgbe_pci_dev_ids.h
> 
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index
> 72426f3..a8899b8 100644


More information about the dev mailing list