[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

[David Harton (dharton)]

Happy Friday,

> -----Original Message-----
> From: Remy Horton [mailto:remy.horton at intel.com]
> Sent: Friday, April 29, 2016 6:22 AM
> To: David Harton (dharton) <dharton at cisco.com>; Tahhan, Maryam
> <maryam.tahhan at intel.com>; dev at dpdk.org
> Cc: Mcnamara, John <john.mcnamara at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>
> Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from
> xstats
> 
> Morning,
> 
> On 28/04/2016 16:58, David Harton (dharton) wrote:
[...]
> 
> > Maybe I misread the patch series or missed one but I don't see where
> > stats can be obtained without copying strings?  This is the real issue
> > I raised originally.
> 
> See http://dpdk.org/dev/patchwork/patch/12096/ where xstats[].key is used
> to lookup string from ptr_names[].name - I didn't delete the name field
> from rte_eth_xstats because doing so would cause a compile error with the
> drivers I've not yet converted.

Ok, this was one of my fundamental hang ups.  I didn't see any gain because
of the way the proposal is being introduced.  I guess you are saying that
not only will drivers be added in future patch series but that you also
intend to continue modifying the external API as well.

I will start a clean thread and reply/review the provided patches and forgo
my work.

Cheers,
Dave

> 
> 
> 
> > I did not add "get the count" because it wasn't provided in the
> > current API and instead followed the convention but I do believe
> > overtly getting the count it is the better approach.
> 
> I didn't either for the same reason, but if the API is going to be broken,
> I think it should be added.
> 
> 
> ..Remy