[dpdk-dev] [PATCH v1] doc: add details of sub-trees and maintainers
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue Dec 6 18:32:37 CET 2016
Thanks for documenting the process, John.
2016-12-02 16:44, John McNamara:
> +The role of the component maintainers is to:
> +
I would add:
* Coordinate how improvements and fixes are done.
> +* Review patches for the component or delegate the review.
> + This should be done, ideally, within 1-2 weeks of submission to the mailing list.
> +* Add an ``acked-by`` to patches, or patchsets, that they agree are ready for committing to a tree.
I do not understand "that they agree are ready"
> +Component maintainers can be added or removed by submitting a patch to the ``MAINTAINERS`` file.
> +Maintainers should have demonstrated a reasonable level of contributions to the component area or to a similar area.
I suggest "a reasonable level of contributions or reviews for the component area".
> +This should be confirmed by an ``ack`` from an established contributor.
> +There can be more than one component maintainer if desired.
> +
> +The role of the tree maintainers is to:
> +
> +* Maintain the overall quality of their tree.
> + This can entail additional review, compilation checks or other tests deemed necessary by the maintainer.
> +* Commit reviewed patches.
We need to explain that a tree maintainer rely on component maintainers
and also on any contributor doing a review. However he does not give
the same credit to everyone. It is a matter of trust.
When a not (yet) trusted contributor gives an opinion, it may need
more checks or opinions.
> +* Prepare the tree for integration.
They are responsibles of the pace, giving time for reviews and tests while releasing in time.
> +Tree maintainers can be added or removed by submitting a patch to the ``MAINTAINERS`` file.
> +The proposer should justify the need for a new sub-tree and should have demonstrated a sufficient level of contributions in the area or to a similar area.
> +This should be confirmed by 3 ``acks`` from established contributors.
In practice, people do not give acks because it is obvious.
I think there is no need to add the 3 acks rule because of the line below.
> +Disagreements on trees or maintainers can be brought to the Technical Steering Committee.
Its name is still the "Technical Board".
> +Tree backup maintainers, when required, can be selected from the active tree maintainers.
> +This can be agreed and coordinated by the tree maintainers.
OK, thanks
More information about the dev
mailing list