[dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Dec 7 11:40:28 CET 2016


2016-12-07 15:43, Shreyansh Jain:
> IMO, the way Bus is kept is debatable.
>   - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus 
> patches) [1]?
>   - Should it a 'handler/driver' parallel to device drivers?
> 
> I personally prefer a clean layer for buses with:
> 
>   - RTE_SDK/drivers/net/dpaa2/
>   - RTE_SDK/drivers/bus
>   - RTE_SDK/drivers/bus/dpaa2/
>   - RTE_SDK/drivers/bus/dpaa2/dpaa2_bus.c etc.

I agree, it is a good idea.

> For PCI, which is generic (or for other similar generic buses, like 
> platform), we can keep the implementation within lib/librte_eal/linuxapp/*.

I would be in favor of moving PCI and vdev code from EAL to drivers/bus/.
We can keep the API in EAL and implement the buses as drivers.

Other opinions?


More information about the dev mailing list