[dpdk-dev] [PATCH] Force python scripts to run with python2

Mcnamara, John john.mcnamara at intel.com
Thu Dec 8 10:07:22 CET 2016


> -----Original Message-----
> From: Martin Kletzander [mailto:mkletzan at redhat.com]
> Sent: Thursday, December 8, 2016 8:40 AM
> To: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Cc: dev at dpdk.org; Mcnamara, John <john.mcnamara at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] Force python scripts to run with python2
> 
> On Wed, Dec 07, 2016 at 03:48:37PM +0100, Thomas Monjalon wrote:
> >2016-12-07 12:04, Mcnamara, John:
> >> > -----Original Message-----
> >> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Martin
> >> > Kletzander
> >> > Sent: Wednesday, December 7, 2016 10:17 AM
> >> > To: dev at dpdk.org
> >> > Subject: [dpdk-dev] [PATCH] Force python scripts to run with
> >> > python2
> >> >
> >> > With python3 being the default in some distributions/installations,
> >> > shebang with just "python" will make the script run under version
> >> > of python that the scripts are not written for.  In order to fix
> >> > that and mitigate future errors, use shebang properly and specify
> >> > the python version.  That way the scripts will run in any
> >> > distro/install, no matter what python version is set as the default.
> >>
> >> I think a better approach would be to make the scripts Python 2 and
> Python 3 compatible.
> >>
> >> Some of the new ones already are.
> >
> >Yes
> >
> >The "solution" using python2 in the shebang does not work everywhere
> >because python2 can be an unknown command.
> 
> I have not come across a system that would not have python2 as at least a
> symlink or an executable.  However if that is the concern, I can have a
> look at making all scripts python3 compatible, although I'm not yet
> familiar enough with DPDK to be able to properly test all of them.  So
> I'll try and ask if needed.
> 
> Thanks for the input.
> 

Hi Martin,

I'll work on adding Python2/3 compatibility, and while I'm at it PEP8 compatibility.

John





More information about the dev mailing list