[dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

[Alejandro Lucero]

On Tue, Dec 20, 2016 at 10:29 AM, Alejandro Lucero <
alejandro.lucero at netronome.com> wrote:

>
>
> On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit <ferruh.yigit at intel.com>
> wrote:
>
>> On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
>> > I forgot one thing: to update the features file with this new one.
>> >
>> > I will wait for your feedback regarding the discussed problem for
>> > sending another version.
>>
>> I think it is good to go, please send updated version.
>>
>>
> OK
>
>
>> >
>>
>> <...>
>>
>> >
>> >         Sorry, confused. Is it like following:
>> >
>> >         "
>> >         For new FW, there is no problem, it supports the range between
>> >         1G - 50G,
>> >         and reports correct current speed.
>> >
>> >         With old FW, device still can be set to speed range between 1G -
>> >         50G,
>> >         but it doesn't report current speed correct, and DPDK driver
>> reports
>> >         back to application as device current speed is 40G, without
>> really
>> >         knowing the current speed.
>> >         "
>> >
>> >
>> >     Yes, that is. Should then I do anything else or the patch is right
>> >     for you now?
>>
>> So, this patch is correct.
>>
>> But for the previous patch "net/nfp: report link speed using hardware
>> info", it would be nice to add above information into source as comment
>> and into commit log.
>> If you can, would you mind sending a new version of that patch?
>>
>>
>
Would it be better to report ETH_SPEED_NUM_NONE instead of
ETH_SPEED_NUM_40G for old firmware?
I will add a comment about why, but I think this is better for the user not
getting (sometimes) the right speed.


> I'll do it.
>
> Thanks!
>
>
>> Thanks,
>> ferruh
>>
>> >
>> <...>
>>
>
>