[dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

Mody, Rasesh Rasesh.Mody at cavium.com
Wed Dec 21 00:29:35 CET 2016


> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Thursday, December 08, 2016 8:49 AM
> 
> On 12/3/2016 2:43 AM, Harish Patil wrote:
> > From: Rasesh Mody <Rasesh.Mody at cavium.com>
> >
> > Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with
> > CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value
> > where each bit represent a particular submodule to debug. Also move
> > notice messages under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO.
> >
> > Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> > Signed-off-by: Rasesh Mody <Rasesh.Mody at cavium.com>
> > ---
> 
> Is 32bit supported by driver?

We compile test our drivers for 32bit.
 
> If so it is throwing a compilation error for it [1], if not can you please
> document it?
> 
> [1]
> In file included from .../drivers/net/qede/base/ecore.h:35:0,
>                  from .../drivers/net/qede/qede_ethdev.h:22,
>                  from .../drivers/net/qede/qede_ethdev.c:9:
> .../drivers/net/qede/qede_ethdev.c: In function 'qede_rss_hash_update':
> .../drivers/net/qede/base/../qede_logs.h:33:3: error: format '%lx'
> expects argument of type 'long unsigned int', but argument 7 has type
> 'uint64_t {aka long long unsigned int}' [-Werror=format=]
>    "[%s:%d(%s)]" fmt, \
>    ^
> .../drivers/net/qede/qede_ethdev.c:1472:2: note: in expansion of macro
> 'DP_INFO'
>   DP_INFO(edev, "RSS hf = 0x%lx len = %u key = %p\n", hf, len, key);
>   ^~~~~~~
> cc1: all warnings being treated as errors

We'll fix the compilation error.

> 
> 
> <...>


More information about the dev mailing list