[dpdk-dev] [PATCH v2 1/5] lib: distributor performance enhancements

[Hunt, David]

Thanks for the review, Jerin, I very much appreciate it. I'll address 
all the minor comments, and I've a comment or two on the remaining 
changes below.


On 22/12/2016 12:47 PM, Jerin Jacob wrote:

> On Thu, Dec 22, 2016 at 04:37:04AM +0000, David Hunt wrote:
>

--snip--

>> +
>> +	/* set the GET_BUF but even if we got no returns */
>> +	buf->retptr64[0] |= RTE_DISTRIB_GET_BUF;
>> +
>> +	return 0;
>> +}
>> +
>> +#if RTE_MACHINE_CPUFLAG_SSE2
>> +static inline void
> Move SSE version of the code to separate file so that later other SIMD arch
> specific version like NEON can be incorporated.
>

Sure. Will do. I'll model it on the i40e SIMD layout.


>> +		switch (d->dist_match_fn) {
>> +#ifdef RTE_MACHINE_CPUFLAG_SSE2
> Is this conditional compilation flag is really required ? i.e
> RTE_DIST_MATCH_SSE will not enabled in non SSE case

So I can always leave the call to find_match_sse2 in there, but the 
run-time cpu flags check will
take care of whether it's called or not? OK sure.


Thanks,
Dave.