[dpdk-dev] [PATCH v2 01/16] fm10k: use default mailbox message handler for pf

[Wang, Xiao W]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, February 16, 2016 6:50 PM
> To: Wang, Xiao W <xiao.w.wang at intel.com>
> Cc: Chen, Jing D <jing.d.chen at intel.com>; dev at dpdk.org; He, Shaopeng
> <shaopeng.he at intel.com>
> Subject: Re: [PATCH v2 01/16] fm10k: use default mailbox message handler for
> pf
> 
> On Wed, Jan 27, 2016 at 11:50:32AM +0800, Wang Xiao W wrote:
> > The new share code makes fm10k_msg_update_pvid_pf function static, so
> > we can not refer to it now in fm10k_ethdev.c. The registered pf
> > handler is almost the same as the default pf handler, removing it has no
> impact on mailbox.
> >
> > Signed-off-by: Wang Xiao W <xiao.w.wang at intel.com>
> 
> While the patch itself looks ok, checkpatch gives a warning about the commit
> message being too long.
> 
>   WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit
> description (prefer a
>   maximum 75 chars per line)
>   #6:
>   The new share code makes fm10k_msg_update_pvid_pf function static, so we
> can
> 
>   total: 0 errors, 1 warnings, 0 checks, 31 lines checked
> 
> Since the next patch breaks compilation, a V3 will be needed, so please fix this
> warning in the process. I'd also ask that you run checkpatch on all patches
> before submitting and fix any issue raised.

Thanks for the comment, I used an old checkpatch.pl to check the patches, it gave
no warning. I have updated the checkpatch.pl and got the above warning.
I will rework the patch set, thanks again.

> 
> Thanks,
> /Bruce