[dpdk-dev] [PATCH 4/6] qede: add driver common module

Harish Patil harish.patil at qlogic.com
Tue Feb 23 20:44:30 CET 2016


>
>On Sat, 20 Feb 2016 07:58:31 -0800
><harish.patil at qlogic.com> wrote:
>
>> +unsigned long log2_align(unsigned long n)
>> +{
>
>Common code is good, but you need to practice good function name
>hygiene on public functions to avoid any namespace clashes when
>using static linking.
>
>The application might define a function with log2_align.
>Either make the functions static, or use a common prefix for all qede
>internal functions.
>

Sure. Will fix those



More information about the dev mailing list