[dpdk-dev] [RESEND PATCH] vhost_user: Make sure that memory map is set before attempting address translation

Xie, Huawei huawei.xie at intel.com
Mon Jan 18 18:29:48 CET 2016


On 1/15/2016 4:10 PM, Pavel Fedin wrote:
>  Hello!
>
>> If this is the case, i am wondering whether we should include
>> "malfunctioning clients" in commit message. It triggers me to think if
>> there are existing buggy implementations.
>  Well... Can you suggest how to rephrase it? May be "if a client is malfunctioning it can..."? I lack fantasy, really, and to tell
> the truth i don't care that much about the exact phrasing, i'm OK with everything.

Thanks.
Because there are not any existing malfunctioning clients which doesn't
send SET_MEM_TABLE message and we think the check is OK anyway,
personally I prefer simple phrases like: check memory table in
SET_VRING_ADDR message.

>
>> Anyway, check is OK.
> Kind regards,
> Pavel Fedin
> Senior Engineer
> Samsung Electronics Research center Russia
>
>
>



More information about the dev mailing list