[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Jul 11 07:56:16 CEST 2016


2016-07-11 13:33, Yuanhan Liu:
> On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote:
> > 2016-04-20 14:43, David Marchand:
> > > test application and kni still want to know e1000 pci devices.
> > > So let's create headers in the driver that will be used by them.
> > 
> > There is also an usage of ixgbe ID for the broken bypass API.
> > 
> > Sharing those PCI ids outside of the drivers was really a wrong idea.
> > So this a plan to get rid of them:
> > 
> > 1/ remove need in PCI autotest (done: http://dpdk.org/commit/1dbba165)
> > 2/ move PCI ids in bnx2x, bnxt, e1000, enic, fm10k, i40e, virtio, vmxnet3
> > 3/ remove KNI ethtool (only igb/ixgbe support)
> > 4/ remove bypass API or move it to ixgbe specific API
> > 5/ move remaining PCI ids in igb and ixgbe drivers
> > 
> > Please driver maintainers, move your PCI ids in your drivers as soon as
> > possible. Thanks
> 
> Hi Thomas,
> 
> I'm not quite sure I understood it well: are you asking us to resend
> what David has already send, say me for resending the virtio part?
> 
> If so, what's the point of that? What's worse, it's likely to fail
> apply (due to conflicts), as every one of us make a patch based on
> the same base while touching some same files.

Good point.
There were some changes since the patches from David (and a new bnxt).
That's why I was thinking to ask maintainers to take care of this change.
But maybe it's better to do the change in one patchset.
David, ok to refresh these patches?


More information about the dev mailing list