[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

[Zhang, Helin]

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, July 11, 2016 3:29 PM
> To: Zhang, Helin <helin.zhang at intel.com>; Thomas Monjalon
> <thomas.monjalon at 6wind.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH] i40e: move PCI device ids to driver
> 
> Hi, helin
> 
> What I did is exactly same as what David's patch set did in i40e. I agree with his
> change.
> About the new header file, there is already i40e_devids.h in base code which
> defines the device IDs and vendor ID. This patch just combines them to be a pci
> device id in struct pci_id_i40e_map in source file. So I don't think a new header
> file is required. And about kernel driver, I checked it and it did in the similar way.
OK, I agree with you of that. Thanks!

Helin

> 
> Thanks
> Jingjing
> 
> > -----Original Message-----
> > From: Zhang, Helin
> > Sent: Monday, July 11, 2016 3:02 PM
> > To: Thomas Monjalon
> > Cc: Wu, Jingjing; dev at dpdk.org
> > Subject: RE: [PATCH] i40e: move PCI device ids to driver
> >
> > Hi Thomas
> >
> > It should be the one from David as I read that before. I am not sure
> > if all PMD has its own header files for device IDs, but I did see there was.
> > Even in recent kernel drivers (e.g. i40e), there is a new header file
> > for device ID list. I think it could be clearer, though no correct or wrong.
> >
> > Regards,
> > Helin
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > Sent: Monday, July 11, 2016 2:55 PM
> > > To: Zhang, Helin
> > > Cc: Wu, Jingjing; dev at dpdk.org
> > > Subject: Re: [PATCH] i40e: move PCI device ids to driver
> > >
> > > Hi Helin,
> > >
> > > 2016-07-11 06:19, Zhang, Helin:
> > > > Hi Jingjing
> > > >
> > > > I'd suggest to add a new header file in each PMD to define what we
> > defined
> > > in rte_pci_dev_ids.h.
> > >
> > > Why?
> > >
> > > > There was a patch set submitted several months ago, like that.
> > >
> > > Which one?