[dpdk-dev] spinlock: Move constructor function out of header file

[Thomas Monjalon]

2016-07-14 18:10, Damjan Marion:
> Dear Jan,
> 
> Thank you for your comments. A bit too much overhead to submit simple patch
> so let’s forget about it. I will just add it as it is to our private
> collection of patches.

These are changes trivial to fix when applying.
I strongly prefer that you upstream patches instead of keeping patches
in the VPP repository. I will help you in this task.
Thanks for the effort.

> If anybody wants to pick it from here, please do...

I can update the bsdapp Makefile and do the trivial changes for you,
if we agree that we do not need to touch to other archs (see below).


> > On 14 Jul 2016, at 20:03, Jan Viktorin <viktorin at rehivetech.com> wrote:
> >> --- a/lib/librte_eal/linuxapp/eal/Makefile
> >> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> >> @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c
> >> 
> >> # from arch dir
> >> SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c
> >> +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c
> > 
> > This is not good, you provide rte_spinlock.c only for x86. Building
> > for any other arch would fail to find this file.

It is not used in other archs. It is really x86 specific.

> > Moreover, the bsdapp/eal/Makefile should reflect this situation as
> > well.

Good catch.