[dpdk-dev] [PATCH v6 1/5] mempool: support external handler

Hunt, David david.hunt at intel.com
Thu Jun 2 11:11:38 CEST 2016

On 6/1/2016 6:54 PM, Jan Viktorin wrote:
> Hello David,
> the rename s/handler/ops/ has a lot of residues. Sorry for that :). I tried to
> mark most of them. Otherwise, I couldn't see many more serious issues for now.

Ah, I had assumed that we were just talking about the 
rte_mempool_handler_ops structure,
not a global replace of 'handler' with 'ops'.  It does make sense to 
change it to ops, so we don't have
two words describing the same entity. I'll change to ops.

Just, note the s/pool/priv/ rename suggestion.

I prefer your suggestion of pdata rather than priv, how about "pool_data"?

Again, thanks for the comprehensive review.



More information about the dev mailing list