[dpdk-dev] [PATCH v4 30/39] bnxt: add start/stop/link update operations

Bruce Richardson bruce.richardson at intel.com
Wed Jun 8 12:41:50 CEST 2016


On Wed, Jun 08, 2016 at 11:02:08AM +0100, Bruce Richardson wrote:
> On Mon, Jun 06, 2016 at 03:08:34PM -0700, Stephen Hurd wrote:
> > From: Ajit Khaparde <ajit.khaparde at broadcom.com>
> > 
> > This patch adds code to add the start, stop and link update dev_ops.
> > The BNXT driver will now minimally pass traffic with testpmd.
> > 
> > v4:
> > - Fix issues pointed out by checkpatch.
> > - Shorten the string passed for reserving memzone
> > when default completion ring is created.
> > 
> > Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> > Reviewed-by: David Christensen <david.christensen at broadcom.com>
> > Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_ethdev.c | 269 +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 269 insertions(+)
> > 
> I get compilation errors after applying this patch:
> 
> == Build drivers/net/bnxt
>   CC bnxt_ethdev.o
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_init_chip’:
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:7: error: implicit declaration of function ‘bnxt_alloc_hwrm_rings’ [-Werror=implicit-function-declaration]
>   rc = bnxt_alloc_hwrm_rings(bp);
>        ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:2: error: nested extern declaration of ‘bnxt_alloc_hwrm_rings’ [-Werror=nested-externs]
>   rc = bnxt_alloc_hwrm_rings(bp);
>   ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_init_nic’:
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2: error: implicit declaration of function ‘bnxt_init_ring_grps’ [-Werror=implicit-function-declaration]
>   bnxt_init_ring_grps(bp);
>   ^
> /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2: error: nested extern declaration of ‘bnxt_init_ring_grps’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> /home/bruce/next-net/dpdk-next-net/mk/internal/rte.compile-pre.mk:126: recipe for target 'bnxt_ethdev.o' failed
> make[5]: *** [bnxt_ethdev.o] Error 1
> 
Please ignore, my mistake, as I was missing patch 28.

/Bruce


More information about the dev mailing list