[dpdk-dev] [PATCH] doc: virtio pmd versions

Mcnamara, John john.mcnamara at intel.com
Thu Jun 9 14:56:20 CEST 2016


> -----Original Message-----
> From: Richardson, Bruce
> Sent: Thursday, June 9, 2016 1:53 PM
> To: Mcnamara, John <john.mcnamara at intel.com>; Wang, Zhihong
> <zhihong.wang at intel.com>; dev at dpdk.org
> Cc: Wang, Zhihong <zhihong.wang at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versions
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John
> <snip>
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhihong Wang
> <snip>
> > > +
> > > +Virtio PMD Versions
> > > +-------------------
> > > +
> > > +Virtio driver has 3 versions of rx functions and 2 versions of tx
> > > functions.
> >
> > In some places RX/TX is used and in some rx/tx. I would suggest the
> > uppercase versions throughout.
> >
> 
> In the commit logs, the only valid contractions allowed by the check-git-
> log.sh script are Rx and Tx
> 
> bad=$(echo "$headlines" | grep -E --color=always \
>         -e '\<(rx|tx|RX|TX)\>' \
> 	 ....
> 
> I would therefore suggest we follow the same rules for the docs for
> consistency.

Hi,

I don't mind what it is once we have consistency, so Rx/Tx is fine. Zhihong, 
please note.

John





More information about the dev mailing list