[dpdk-dev] [PATCH] i40e: unintended sign extension

Bruce Richardson bruce.richardson at intel.com
Thu Jun 9 17:14:08 CEST 2016

On Fri, May 20, 2016 at 03:03:36PM +0200, Slawomir Mrozowicz wrote:
> Suspicious implicit sign extension: pf->fdir.match_counter_index
> with type unsigned short (16 bits, unsigned) is promoted in
> pf->fdir.match_counter_index << 20 to type int (32 bits, signed),
> then sign-extended to type unsigned long (64 bits, unsigned).
> If pf->fdir.match_counter_index << 20 is greater than 0x7FFFFFFF,
> the upper bits of the result will all be 1.
> To fix the issue set explicit cast uint32_t of pf->fdir.match_counter_index.
> Fixes: 05999aab4ca6 ("i40e: add or delete flow director")
> Coverity ID 13315
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz at intel.com>

Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Applied to dpdk-next-net/rel_16_07


More information about the dev mailing list