[dpdk-dev] [PATCH] mbuf: remove unused Rx error flags

Ananyev, Konstantin konstantin.ananyev at intel.com
Mon Jun 13 14:42:17 CEST 2016


Hi Olivier,

> > -----Original Message-----
> > From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > Sent: Monday, May 23, 2016 8:56 AM
> > To: dev at dpdk.org
> > Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon at qwilt.com; rolette at infinite.io; Chen, Jing D; Wu, Jingjing
> > Subject: [PATCH] mbuf: remove unused Rx error flags
> >
> > Following the discussions from:
> > http://dpdk.org/ml/archives/dev/2015-July/021721.html
> > http://dpdk.org/ml/archives/dev/2016-April/038143.html
> >
> > The value of these flags is 0, making them useless. Today, no example
> > application checks them on Rx, and only few drivers sets them and
> > silently give wrong packets to the application, which should not happen.
> >
> > This patch removes the unused flags from rte_mbuf and their use in the
> > drivers. The i40e and fm10k are kept as they are today and should be
> > fixed to drop bad packets. The enic driver is managed by its maintainer
> > in another patch.
> >
> > Fixes: c22265f6 ("mbuf: add new packet flags for i40e")
> > Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> > ---
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>


Just a note, I think you'll need to rebase your patch with latest code.
enic PMD fails to compile.
Please feel free to keep my ack on it.
Konstantin




More information about the dev mailing list