[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

Remy Horton remy.horton at intel.com
Mon Jun 13 17:51:02 CEST 2016

On 12/06/2016 15:51, Zyta Szpak wrote:
>     I would prefer having only one function rte_eth_dev_get_regs()
>     which returns length and width if data is NULL.
>     The first call is a parameter request before buffer allocation,
>     and the second call fills the buffer.
>     We can deprecate the old API and introduce this new one.
>     Opinions?
> In my opinion as it is now it works fine. Gathering all parameters in
> one callback might be a good idea if the maintainer also agrees to that
> because as I mentioned, it interferes.

 From my perspective changing rte_eth_dev_get_regs() isn't a problem, as 
it isn't used directly rather than through rte_ethtool_get_regs()..


More information about the dev mailing list