[dpdk-dev] [PATCH 02/29] ixgbe/base: add sgmii link for X550

[Ferruh Yigit]

On 5/6/2016 7:07 AM, Beilei Xing wrote:
> It adds sgmii link for X550.
> 
> Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_type.h |   9 +++
>  drivers/net/ixgbe/base/ixgbe_x550.c | 131 +++++++++++++++++++++++++++++++++---
>  2 files changed, 129 insertions(+), 11 deletions(-)
> 
...

>  	}
> @@ -512,8 +546,8 @@ s32 ixgbe_init_ops_X550EM(struct ixgbe_hw *hw)
>  		link->addr = IXGBE_CS4227;
>  	}
>  	if (hw->mac.type == ixgbe_mac_X550EM_a) {
> -		mac->ops.read_iosf_sb_reg = ixgbe_read_iosf_sb_reg_x550a;
> -		mac->ops.write_iosf_sb_reg = ixgbe_write_iosf_sb_reg_x550a;
> +		mac->ops.read_iosf_sb_reg = ixgbe_read_iosf_sb_reg_x550;
> +		mac->ops.write_iosf_sb_reg = ixgbe_write_iosf_sb_reg_x550;
Is it possible that these lines related to the patch 7:
[PATCH 07/29] ixgbe/base: change access method

It looks like first changes ops from ..x550a to ...x550 here and in
patch 7, using ops function instead fixed one.

Also if there is more details about ..x550a to ...x550 change it can be
good to add patch 7 comment.

>  		mac->ops.acquire_swfw_sync = ixgbe_acquire_swfw_sync_X550a;
>  		mac->ops.release_swfw_sync = ixgbe_release_swfw_sync_X550a;
>  	}
...