[dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function

Jain, Deepak K deepak.k.jain at intel.com
Mon Jun 20 16:30:14 CEST 2016


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, June 20, 2016 10:46 AM
> To: Jain, Deepak K <deepak.k.jain at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>
> Cc: dev at dpdk.org; Griffin, John <john.griffin at intel.com>; Trahe, Fiona
> <fiona.trahe at intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add
> rte_crypto_op_bulk_free function
> 
> 2016-06-16 20:49, Jain, Deepak K:
> > From: Declan Doherty <declan.doherty at intel.com>
> >
> > Adding rte_crypto_op_bulk_free to free up the ops in bulk so as to
> > expect improvement in performance.
> >
> > Signed-off-by: Declan Doherty <declan.doherty at intel.com>
> 
> I wonder why these changes are dropped so late?
 I agree that these changes got late due to more than expected dubugging time spent on performance code.

I will send v2 of the patches without addition of rte_crypto_op_bulk_free.
> 
> >  /**
> > + * free crypto operation structure
> > + * If operation has been allocate from a rte_mempool, then the
> > + operation will
> > + * be returned to the mempool.
> > + *
> > + * @param	op	symmetric crypto operation
> > + */
> 
> Please check punctuation, grammar and document every parameters.
Will not need any changes as in v2, this function will be removed.
> 
> > +static inline void
> > +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct
> rte_crypto_op **ops,
> > +		uint16_t nb_ops)



More information about the dev mailing list