[dpdk-dev] [PATCH v6 04/27] net/thunderx/base: add mbox APIs for PF/VF communication

Ferruh Yigit ferruh.yigit at intel.com
Tue Jun 21 15:41:39 CEST 2016


On 6/17/2016 2:29 PM, Jerin Jacob wrote:
> DPDK nicvf driver doesn't have access to NIC's PF address space.
> Introduce a mailbox mechanism to communicate with PF driver through
> shared 128bit register interface.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Signed-off-by: Maciej Czekaj <maciej.czekaj at caviumnetworks.com>
> Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski at caviumnetworks.com>
> Signed-off-by: Zyta Szpak <zyta.szpak at semihalf.com>
> Signed-off-by: Slawomir Rosek <slawomir.rosek at semihalf.com>
> Signed-off-by: Radoslaw Biernacki <rad at semihalf.com>

...

> +
> +static inline const char *
> +nicvf_mbox_msg_str(int msg)
> +{
> +	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> +	/* undefined messages */
> +	if (mbox_message[msg] == NULL)
> +		msg = 0;
> +	return mbox_message[msg];
> +}

With clang getting following compile error:

== Build drivers/net/thunder
  CC nicvf_mbox.o
/root/development/dpdk-next-net/drivers/net/thunderx/base/nicvf_mbox.c:68:1:
error: unused function 'nicvf_mbox_msg_str' [-Werror,-Wunused-function]
nicvf_mbox_msg_str(int msg)
^
1 error generated.
/root/development/dpdk-next-net/mk/internal/rte.compile-pre.mk:126:
recipe for target 'nicvf_mbox.o' failed


It looks like nicvf_mbox_msg_str() only called within logging functions
which can depends on DEBUC_X config options.


Regards,
ferruh





More information about the dev mailing list