[dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, June 21, 2016 9:49 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Cc: dev at dpdk.org; Singh, Jasvinder <jasvinder.singh at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port
> section
> 
> 2016-06-16 10:04, Jasvinder Singh:
> > Replace APP_PARAM_ADD_LINK_FOR_TXQ with
> APP_PARAM_ADD_LINK_FOR_TM macro
> > in TM (Traffic Manager) port section parsing function. This macro adds
> > nic ports entry specified in TM port section of the application
> > configuration file to the application parameters structure.
> >
> > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration
> parser")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> 
> Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI")
> 
> Cristian, you should not ack a patch which do more than announced in
> the title. This pipeline KNI patch do a lot of things without any
> explanation for the fixes.
> 1 explanation = 1 patch

Yeah, there were several small issues to fix and several people spotted them at the same time. I agree we should do a better job at separating different fixes into different patches. Sorry about this.