[dpdk-dev] [PATCH] enic: fix issues when using Rx scatter with multiple RQs
bruce.richardson at intel.com
Tue Jun 28 13:12:57 CEST 2016
On Fri, Jun 24, 2016 at 03:39:57PM -0700, Nelson Escobar wrote:
> The Rx scatter patch failed to make a few changes and resulted
> in problems when using multiple RQs since the wrong RQ or CQ
> was being used.
I think you might need to expand on what the "few changes" are.
Also, please expand out the terms RQ and CQ are.
> Fixes: 14a261bf0520 ("enic: add scattered Rx support")
> Signed-off-by: Nelson Escobar <neescoba at cisco.com>
> Reviewed-by: John Daley <johndale at cisco.com>
> drivers/net/enic/enic.h | 2 +-
> drivers/net/enic/enic_main.c | 10 ++++++----
> 2 files changed, 7 insertions(+), 5 deletions(-)
> diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
> index ed5f18d..15b1d45 100644
> --- a/drivers/net/enic/enic.h
> +++ b/drivers/net/enic/enic.h
> @@ -174,7 +174,7 @@ static inline unsigned int enic_vnic_rq_count(struct enic *enic)
> static inline unsigned int enic_cq_rq(__rte_unused struct enic *enic, unsigned int rq)
> - return rq;
> + return rq / 2;
This looks like it might need a comment explaning why you divide by 2.
More information about the dev