[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

Bruce Richardson bruce.richardson at intel.com
Thu Jun 30 14:09:50 CEST 2016


On Thu, Jun 30, 2016 at 03:02:22PM +0300, Panu Matilainen wrote:
> On 06/30/2016 03:00 PM, Thomas Monjalon wrote:
> >2016-06-29 17:27, Bruce Richardson:
> >>Fix this by introducing two new functions to replace the old ones,
> >>* rte_mempool_avail_count to replace rte_mempool_count
> >>* rte_mempool_in_use_count to replace rte_mempool_free_count
> >
> >This patch needs to be rebased please.
> >
> >>--- a/lib/librte_mempool/rte_mempool_version.map
> >>+++ b/lib/librte_mempool/rte_mempool_version.map
> >>@@ -32,5 +32,6 @@ DPDK_16.07 {
> >> 	rte_mempool_populate_virt;
> >> 	rte_mempool_register_ops;
> >> 	rte_mempool_set_ops_byname;
> >>+	rte_mempool_avail_count;
> >
> >The "in_use_count" function is missing.
> 
> Its missing because the function is static inline. If you ask me, this would
> be as fine time as any to remove that inlining ;)
> 
> 	- Panu -
> 
Yep, and yep.
V3 needed, I'll see what I can do.

/Bruce

> >Please keep alphabetical order.
> >
> 
> 


More information about the dev mailing list