[dpdk-dev] [PATCH v2] I217 and I218 changes

[Bruce Richardson]

On Tue, Mar 01, 2016 at 03:37:33AM -0800, Ravi Kerur wrote:
> On Mon, Feb 29, 2016 at 9:18 PM, Lu, Wenzhuo <wenzhuo.lu at intel.com> wrote:
> 
> > Hi,
> >
> > > -----Original Message-----
> > > From: Ravi Kerur [mailto:rkerur at gmail.com]
> > > Sent: Tuesday, March 1, 2016 2:31 AM
> > > To: Lu, Wenzhuo; dev at dpdk.org
> > > Cc: Ravi Kerur
> > > Subject: [PATCH v2] I217 and I218 changes
> > >
> > > v2:
> > >       Incorporate Wenzhou's comments
> > >       Compiled and tested (via testpmd) on Ubuntu 14.04 on target
> > >               x86_64-native-linuxapp-gcc
> > >       Compiled for target x86_64-native-linuxapp-clang
> > >
> > > v1:
> > >       Modified driver and eal code to recognize and support I217 and
> > >       I218 Intel NICs.
> > >       Compiled and tested (via testpmd) on Ubuntu 14.04 for target
> > >               x86_64-native-linuxapp-gcc
> > >       Compiled for target x86_64-native-linuxapp-clang
> > >
> > > Signed-off-by: Ravi Kerur <rkerur at gmail.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> > But the v1, v2 info in the commit log is a little strange. For you didn't
> > send a v1 and others don't know our discussion :)
> >
> > Do you want me to resend it as 'v1' and include your comments in commit
> message? let me know.
> 
> Thanks.
At this stage having a V1 follow a V2 would be confusing. Can you send a V3 with
a proper commit message describing the change in some detail. The v2->v3 history
please place below the cut line "---" after the signoff.

Regards,
/Bruce