[dpdk-dev] New driver (large patch) question.

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Mar 2 22:54:15 CET 2016


2016-03-02 13:30, Stephen Hurd:
> The bulk of the patch is the hardware interface header file.  With all the
> comments, it weighs in around 800k.  If I strip the comments, it's around
> 300k.  If I both strip all the comments and remove all the currently unused
> structures, I can get the entire patch down just below 300k, but that makes
> it much harder for someone to do further development.  I'm willing to do
> that though if it's what's preferred.
> 
> The other large file (560k) is just a bunch of extra debug output that
> makes it easier to debug issues.  It's normally not compiled, so it sounds
> like it's not wanted either.

If the code is not needed, it's obviously better to not submit it :)

> I'll submit without comments in the hardware interface file and take it
> from there.

I don't think removing the comments is a good option.
Please try to split per-feature to make it readable.
You can check how fm10k was introduced as an example:
	http://thread.gmane.org/gmane.comp.networking.dpdk.devel/13447
or mlx5:
	http://thread.gmane.org/gmane.comp.networking.dpdk.devel/26986


More information about the dev mailing list