[dpdk-dev] [PATCH v5 0/2] cryptodev API changes

Trahe, Fiona fiona.trahe at intel.com
Fri Mar 4 19:01:26 CET 2016



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, March 04, 2016 5:46 PM
> To: Trahe, Fiona
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes
> 
> 2016-03-04 17:43, Trahe, Fiona:
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > 2016-03-04 17:17, Fiona Trahe:
> > > > This patch set separates the symmetric crypto operations from
> > > > generic
> > > operations and then modifies the cryptodev burst API to accept
> > > bursts of rte_crypto_op rather than rte_mbufs.
> > > >
> > > > V5:
> > > > - updates .map file
> > > > - removes EXPERIMENTAL label from rte_cryptodev.h
> > >
> > > Why do you want to remove the experimental label?
> >
> > Declan had already removed from the MAINTAINERS file and other places in
> previous  patches.
> > This one was just forgotten as far as we know, though as Declan is out we
> can't confirm with him.
> > Do you think we should keep the label ?
> 
> I cannot really decide because it's hard to understand the improvements in a
> such big patch. It would be easier if the changes were split in several steps.
> Maybe the last step (last patch) would be to remove the flag. Having it in a
> separate patch would give the opportunity to detail the reason of the removal in
> the commit message.

Fair enough.
I'll put the label back in.
And we'll handle later with a separate explicit commit to give people a chance to comment.


More information about the dev mailing list