[dpdk-dev] [PATCH v4] librte_pipeline: add support for packet redirection at action handlers

Singh, Jasvinder jasvinder.singh at intel.com
Mon Mar 7 12:29:14 CET 2016


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, March 7, 2016 11:02 AM
> To: Singh, Jasvinder <jasvinder.singh at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] librte_pipeline: add support for packet
> redirection at action handlers
> 
> Hi Jasvinder,
> 
> Don't hesitate to leave some blank lines in your message, it's free :)

I will avail free service ;) thanks
 
> 2016-03-03 11:01, Jasvinder Singh:
> > Currently, there is no mechanism that allows the pipeline ports
> > (in/out) and table action handlers to override the default forwarding
> > decision (as previously configured per input port or in the table
> > entry). Therefore, new pipeline API functions have been added which
> > allows action handlers to hijack packets and remove them from the
> > pipeline processing, and then either drop them or send them out of the
> > pipeline on any output port. The port
> > (in/out) and table action handler prototypes have been changed for
> > making use of these new API functions. This feature will be helpful to
> > implement functions such as exception handling (e.g. TTL =0), load
> balancing etc.
> > Changes are made to the ports and table action handlers defined in
> > app/test_pipeline and ip_pipeline sample application.
> 
> I have the feeling it would be easier to parse if the structure changes were
> done in a separate commit, then introduce the new function.

I will send v5 as you advice.

> You have forgotten to remove the deprecation notice.

I think, I have updated the deprecation notice for the pipeline input port, output port
and table action handlers prototype. Do you mean anything else than this?


Thanks,
Jasvinder



More information about the dev mailing list